Skip to content

AMBARI-26568: Fixing IllegalArgumentException: argument src is null d… #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
basapuram-kumar wants to merge 1 commit into
base: trunk
Choose a base branch
from
+12 −1
Open

AMBARI-26568: Fixing IllegalArgumentException: argument src is null d… #4100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ambari-server/src/main/java/org/apache/ambari/server/stack/ThemeModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ public ThemeModule(File themeFile, ThemeInfo moduleInfo) {
try {
reader = new FileReader(themeFile);
} catch (FileNotFoundException e) {
LOG.error("Theme file not found");
LOG.error("Theme file not found: {}", themeFile.getAbsolutePath());
setValid(false);
addError("Theme file not found: " + themeFile.getAbsolutePath());
return;
}
try {
Theme theme = mapper.readValue(reader, Theme.class);
Expand All @@ -70,6 +73,14 @@ public ThemeModule(File themeFile, ThemeInfo moduleInfo) {
LOG.error("Unable to parse theme file ", e);
setValid(false);
addError("Unable to parse theme file " + themeFile);
} finally {
if (reader != null) {
try {
reader.close();
} catch (IOException e) {
LOG.warn("Failed to close theme file reader", e);
}
}
}
}
}
Expand Down