[Subtask]: Use a new configuration item to control whether master & slave mode is enabled. #3846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lave mode is enabled. apache#3845
…lave mode is enabled. apache#3845
xxubai
reviewed
Nov 21, 2025
Contributor
xxubai
left a comment
xxubai
left a comment
There was a problem hiding this comment.
Thank you for the contribution — this is an important feature.
| .withDescription("The administrator password"); | ||
|
|
||
| /** Enable master & slave mode, which supports horizontal scaling of AMS. */ | ||
| public static final ConfigOption<Boolean> USE_MASTER_SLAVE_MODE = |
Contributor
There was a problem hiding this comment.
I’m wondering whether we could control the single-node and multi-node modes with a configuration option, with the default being the single-node mode.
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
…e#3847) * rename the sdk pkg * version and artifactId
Change the uri configuration in terminal
* separate * java17 * build * GA * jdk17 tests * fix conflicts * <java.source.version>17</java.source.version> * JDK8 + Spark-3.5 * revert JDK17
…pache#3858) Each version of table metadata is stored in a metadata folder under the table’s base location using a naming scheme that includes a version and UUID: <V>-<random-uuid>.metadata.json.
[AMORO-3850][FOLLOWUP] Add GA for openAPI SDK
Bump spark 3.5 version to 3.5.7
* Build project with fixed version check-latest: false GA * docs * shell
…y artifactId (apache#3861) Using scala.binary.version for dependency artifactId
…ache#3874) * Fix iceberg-spark artifactId in amoro-mixed-spark-3-common * fix ut conflicts
* format * spark profiles
* save * 3.9.9 * mvnw * slash * maven 3.9.11 * maven wrapper 3.3.4
* [AMORO-3880] Make amoro-openapi-sdk standalone * save
….17.2/1.20.3 (apache#3889) bump
* Bump Paimon 1.1.1 to 1.2.0 * [AMORO-3883] Bump Paimon 1.1.1 to 1.2.0 --------- Co-authored-by: Xu Bai <[email protected]>
Support to reformat pom format trino
…apache#3871) * support to customize basic auth" * save * docs * common * address comments * nit --------- Co-authored-by: Xu Bai <[email protected]>
Bump kubernetes-client version to 6.13.5
* scala binary version save bin profile GA revert paimon ams api compatiblity fix flink scala style save save rewrite by scala save conflicts dependency save save scala paimon ignore paimon idea * nit * nit * save * revert ci change
…artifactId change (apache#3912) * fix save * test * Revert "test" This reverts commit 6c38dbd.
…K17+ automatically (apache#3906) reformat
…lave mode is enabled. apache#3845
…lave mode is enabled. apache#3845
support DATABASE HA SERVICE Co-authored-by: dailiang <[email protected]>
…he#3996) [amoro-3994] Support Exposing AMS High Availability (HA) Status Co-authored-by: davedwwang <[email protected]>
…lave mode is enabled. apache#3845
…lave mode is enabled. apache#3845
# Conflicts: # amoro-ams/src/main/java/org/apache/amoro/server/ha/ZkHighAvailabilityContainer.java
github-actions
bot
removed
module:mixed-flink
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3846 +/- ##
============================================
+ Coverage 22.12% 29.38% +7.25%
- Complexity 2461 4329 +1868
============================================
Files 445 700 +255
Lines 40897 56981 +16084
Branches 5767 7145 +1378
============================================
+ Hits 9050 16743 +7693
- Misses 31089 38972 +7883
- Partials 758 1266 +508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
czy006
reviewed
Jan 15, 2026
docs/configuration/ams-config.md
Outdated
| | thrift-server.selector-thread-count | 2 | The number of selector threads for the Thrift server. | | ||
| | thrift-server.table-service.bind-port | 1260 | Port that the table service thrift server is bound to. | | ||
| | thrift-server.table-service.worker-thread-count | 20 | The number of worker threads for the Thrift server. | | ||
| | use-master-slave-mode | false | Enable master & slave mode, which supports horizontal scaling of AMS. | |
Contributor
There was a problem hiding this comment.
e should label it as a testing feature when describing it, only until it can run stably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new configuration item has been added to control whether master & slave mode is enabled, in order to support the horizontal scaling capability of AMS.
Why are the changes needed?
Close #3845
Brief change log
Add a new configuration USE_MASTER_SLAVE_MODE to control whether master & slave mode is enabled.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation