[AMORO-4040] Change default value of optimizer.task-execute-timeout t… #4042
+119
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Long.MAX_VALUE ns
github-actions
bot
added
type:docs
Contributor
Author
klion26
reviewed
Jan 16, 2026
Member
klion26
left a comment
klion26
left a comment
There was a problem hiding this comment.
Thanks for the contribution, left some comments, please let me know what do you think about them.
| .defaultValue(Duration.ofSeconds(30)) | ||
| .withDescription("Timeout duration for task acknowledgment."); | ||
|
|
||
| // defaultValue must be in nanoseconds; otherwise, TimeUtils.formatWithHighestUnit will fail with |
Member
There was a problem hiding this comment.
IIUC we use Duration.ofNanos(Long.MAX_VALUE) instead of Duration.ofHours(xx)(or others) because they will overflow, if this is true, maybe we don't need this comment, or we can move it to the L482
Member
There was a problem hiding this comment.
Could we use the TimeUnit::Second? (may be with Int.MAX_VALUE), Fom my perspective, seconds are used more often than nanoseconds.
| } | ||
| } | ||
|
|
||
| private boolean isTaskExecTimeout(TaskRuntime<?> task) { |
Member
There was a problem hiding this comment.
Thanks for extracting the common logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #4040.
Brief change log
Update the default value of OPTIMIZER_TASK_EXECUTE_TIMEOUT from Duration.ofHours(1) to Duration.ofMillis(Long.MAX_VALUE) ns
How was this patch tested?
[ x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
[x ] Run test locally before making a pull request
Documentation