Release/1.7.1

.gitignore

@@ -28,7 +28,7 @@ vendor/
 /answer-data/
 /answer
 /new_answer
-
+build/tools/
 dist/
 
 # Lint setup generated file

.golangci.yaml

@@ -0,0 +1,49 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: "2"
+linters:
+  exclusions:
+    paths:
+      - answer-data
+      - ui
+      - i18n
+  enable:
+    - asasalint # checks for pass []any as any in variadic func(...any)
+    - asciicheck # checks that your code does not contain non-ASCII identifiers
+    - bidichk # checks for dangerous unicode character sequences
+    - bodyclose # checks whether HTTP response body is closed successfully
+    - canonicalheader # checks whether net/http.Header uses canonical header
+    - copyloopvar # detects places where loop variables are copied (Go 1.22+)
+    - gocritic # provides diagnostics that check for bugs, performance and style issues
+    - misspell # finds commonly misspelled English words in comments and strings
+    - modernize # detects code that can be modernized to use newer Go features
+    - testifylint # checks usage of github.com/stretchr/testify
+    - unconvert # removes unnecessary type conversions
+    - unparam # reports unused function parameters
+    - whitespace # detects leading and trailing whitespace
+
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    gofmt:
+      simplify: true
+      rewrite-rules:
+        - pattern: 'interface{}'
+          replacement: 'any'

Makefile

@@ -1,6 +1,6 @@
 .PHONY: build clean ui
 
-VERSION=1.7.0
+VERSION=1.7.1
 BIN=answer
 DIR_SRC=./cmd/answer
 DOCKER_CMD=docker
@@ -10,6 +10,15 @@ Revision=$(shell git rev-parse --short HEAD 2>/dev/null || echo "")
 GO_FLAGS=-ldflags="-X github.com/apache/answer/cmd.Version=$(VERSION) -X 'github.com/apache/answer/cmd.Revision=$(Revision)' -X 'github.com/apache/answer/cmd.Time=`date +%s`' -extldflags -static"
 GO=$(GO_ENV) "$(shell which go)"
 
+GOLANGCI_VERSION ?= v2.6.2
+TOOLS_BIN := $(shell mkdir -p build/tools && realpath build/tools)
+
+GOLANGCI = $(TOOLS_BIN)/golangci-lint-$(GOLANGCI_VERSION)
+$(GOLANGCI):
+	rm -f $(TOOLS_BIN)/golangci-lint*
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/$(GOLANGCI_VERSION)/install.sh | sh -s -- -b $(TOOLS_BIN) $(GOLANGCI_VERSION)
+	mv $(TOOLS_BIN)/golangci-lint $(TOOLS_BIN)/golangci-lint-$(GOLANGCI_VERSION)
+
 build: generate
 	@$(GO) build $(GO_FLAGS) -o $(BIN) $(DIR_SRC)
 
@@ -23,10 +32,10 @@ universal: generate
 generate:
 	@$(GO) get github.com/swaggo/swag/cmd/[email protected]
 	@$(GO) get github.com/google/wire/cmd/[email protected]
-	@$(GO) get go.uber.org/mock/mockgen@v0.5.0
+	@$(GO) get go.uber.org/mock/mockgen@v0.6.0
 	@$(GO) install github.com/swaggo/swag/cmd/[email protected]
 	@$(GO) install github.com/google/wire/cmd/[email protected]
-	@$(GO) install go.uber.org/mock/mockgen@v0.5.0
+	@$(GO) install go.uber.org/mock/mockgen@v0.6.0
 	@$(GO) generate ./...
 	@$(GO) mod tidy
 
@@ -50,8 +59,12 @@ install-ui-packages:
 ui:
 	@cd ui && pnpm pre-install && pnpm build && cd -
 
-lint: generate
+lint: generate $(GOLANGCI)
+	@bash ./script/check-asf-header.sh
+	$(GOLANGCI) run
+
+lint-fix: generate $(GOLANGCI)
 	@bash ./script/check-asf-header.sh
-	@gofmt -w -l .
+	$(GOLANGCI) run --fix
 
 all: clean build

README.md

@@ -23,7 +23,7 @@ To learn more about the project, visit [answer.apache.org](https://answer.apache
 ### Running with docker
 
 ```bash
-docker run -d -p 9080:80 -v answer-data:/data --name answer apache/answer:1.7.0
+docker run -d -p 9080:80 -v answer-data:/data --name answer apache/answer:1.7.1
 ```
 
 For more information, see [Installation](https://answer.apache.org/docs/installation).
@@ -43,7 +43,7 @@ You can also check out the [plugins here](https://answer.apache.org/plugins).
 - Golang >= 1.23
 - Node.js >= 20
 - pnpm >= 9
-- [mockgen](https://github.com/uber-go/mock?tab=readme-ov-file#installation) >= 1.6.0
+- [mockgen](https://github.com/uber-go/mock?tab=readme-ov-file#installation) >= 0.6.0
 - [wire](https://github.com/google/wire/) >= 0.5.0
 
 ### Build

cmd/wire.go

@@ -1,5 +1,4 @@
 //go:build wireinject
-// +build wireinject
 
 /*
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -32,7 +31,7 @@ import (
 	"github.com/apache/answer/internal/base/server"
 	"github.com/apache/answer/internal/base/translator"
 	"github.com/apache/answer/internal/controller"
-	"github.com/apache/answer/internal/controller/template_render"
+	templaterender "github.com/apache/answer/internal/controller/template_render"
 	"github.com/apache/answer/internal/controller_admin"
 	"github.com/apache/answer/internal/repo"
 	"github.com/apache/answer/internal/router"

docs/docs.go

@@ -8080,9 +8080,6 @@ const docTemplate = `{
                 "id": {
                     "type": "string"
                 },
-                "question_id": {
-                    "type": "string"
-                },
                 "title": {
                     "type": "string"
                 }
@@ -9780,8 +9777,6 @@ const docTemplate = `{
         "schema.QuestionAdd": {
             "type": "object",
             "required": [
-                "content",
-                "tags",
                 "title"
             ],
             "properties": {
@@ -9796,7 +9791,7 @@ const docTemplate = `{
                     "description": "content",
                     "type": "string",
                     "maxLength": 65535,
-                    "minLength": 6
+                    "minLength": 0
                 },
                 "tags": {
                     "description": "tags",
@@ -9817,8 +9812,6 @@ const docTemplate = `{
             "type": "object",
             "required": [
                 "answer_content",
-                "content",
-                "tags",
                 "title"
             ],
             "properties": {
@@ -9838,7 +9831,7 @@ const docTemplate = `{
                     "description": "content",
                     "type": "string",
                     "maxLength": 65535,
-                    "minLength": 6
+                    "minLength": 0
                 },
                 "mention_username_list": {
                     "type": "array",
@@ -10119,9 +10112,7 @@ const docTemplate = `{
         "schema.QuestionUpdate": {
             "type": "object",
             "required": [
-                "content",
                 "id",
-                "tags",
                 "title"
             ],
             "properties": {
@@ -10136,7 +10127,7 @@ const docTemplate = `{
                     "description": "content",
                     "type": "string",
                     "maxLength": 65535,
-                    "minLength": 6
+                    "minLength": 0
                 },
                 "edit_summary": {
                     "description": "edit summary",
@@ -10926,7 +10917,7 @@ const docTemplate = `{
                 },
                 "theme_config": {
                     "type": "object",
-                    "additionalProperties": true
+                    "additionalProperties": {}
                 }
             }
         },
@@ -10941,7 +10932,7 @@ const docTemplate = `{
                 },
                 "theme_config": {
                     "type": "object",
-                    "additionalProperties": true
+                    "additionalProperties": {}
                 },
                 "theme_options": {
                     "type": "array",
@@ -11047,6 +11038,16 @@ const docTemplate = `{
                 "max_image_size": {
                     "type": "integer"
                 },
+                "min_content": {
+                    "type": "integer",
+                    "maximum": 65535,
+                    "minimum": 0
+                },
+                "min_tags": {
+                    "type": "integer",
+                    "maximum": 5,
+                    "minimum": 0
+                },
                 "recommend_tags": {
                     "type": "array",
                     "items": {
@@ -11091,6 +11092,16 @@ const docTemplate = `{
                 "max_image_size": {
                     "type": "integer"
                 },
+                "min_content": {
+                    "type": "integer",
+                    "maximum": 65535,
+                    "minimum": 0
+                },
+                "min_tags": {
+                    "type": "integer",
+                    "maximum": 5,
+                    "minimum": 0
+                },
                 "recommend_tags": {
                     "type": "array",
                     "items": {