feat(workflow/e2e): allow workflow_dispatch trigger tests#3109
Merged
SkyeYoung merged 1 commit intoapache:masterfrom Jun 9, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enable manual invocation of the end-to-end test workflow alongside scheduled and label-triggered runs
- Add
workflow_dispatchevent trigger for on-demand test execution - Update job
ifcondition to includeworkflow_dispatchalongside schedule and label checks
Comments suppressed due to low confidence (2)
.github/workflows/e2e.yml:24
- [nitpick] Clarify the comment to mention manual triggers explicitly, e.g.,
# run when e2e-test label is added, on schedule, or via manual workflow_dispatch.
# only run when e2e-test label is added, scheduled, workflow_dispatch
.github/workflows/e2e.yml:16
- [nitpick] Consider adding a brief comment above
workflow_dispatchto explain that it enables manual triggering from the GitHub UI.
workflow_dispatch:
4 tasks
bzp2010
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
This is part of the apache/apisix#12234
According to Events that trigger workflows , this will allow us to trigger the test manually.
Why
This is very suitable for manually running a test to ensure that the dashboard can adapt to the latest APISIX, either on the eve of APISIX's release or after the
APISIX:devimage is updated.