fix: preserve plugins with empty config when saving routes #3272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SchemaForm component that renders forms from JSON Schema - Support for oneOf (conditional field groups) - Support for dependencies (conditional fields based on other values) - Reuses existing FormItem components (TextInput, Select, Switch, NumberInput) - Add demo page at /schema_form_demo for testing
Instead of globally disabling emptyObjectsCleaner which broke timeout validation, this fix uses a marker-based approach that only preserves empty objects in the plugins field. Other empty objects (like timeout) are still cleaned as expected. - Add producePreservePlugins to mark empty plugin configs before cleaning - Add produceRemovePreserveMarkers to restore them after cleaning - This prevents both bugs: plugins being dropped AND invalid timeout errors
DSingh0304
force-pushed
the
fix/empty-plugin-config
branch
from
5bc28d4 to
e2d8f6c
Compare
SkyeYoung
reviewed
Jan 8, 2026
Member
There was a problem hiding this comment.
What is the purpose of this form? It seems irrelevant to the title
Contributor
Author
There was a problem hiding this comment.
Yes my bad, the branch i created tracked one of my other branches which was for another issue. Sorry for the confusion I will raise a new PR by creating a new branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why submit this pull request?
What changes will this PR take into?
Fields with empty object values (
{}) were being silently dropped when saving. This affects:key-auth,prometheus,echo)discovery_argswhen using Service DiscoveryRoot Cause: The
fast-cleanlibrary used in src/utils/producer.ts hasemptyObjectsCleaner: trueby default, which removes empty objects before sending data to the server.Fix: Set
emptyObjectsCleaner: falsein the deepCleanEmptyKeys function to preserve empty objects.Related issues
Checklist: