Skip to content

Comments

refactor(ui): introduce ResourceListPage and standardize resource lis…#3305

Open
Baluduvamsi2006 wants to merge 1 commit intoapache:masterfrom
Baluduvamsi2006:refactor/resource-list-page
Open

refactor(ui): introduce ResourceListPage and standardize resource lis…#3305
Baluduvamsi2006 wants to merge 1 commit intoapache:masterfrom
Baluduvamsi2006:refactor/resource-list-page

Conversation

@Baluduvamsi2006
Copy link

What this PR does

This PR introduces a reusable ResourceListPage component and refactors existing resource list pages to use it.

Previously, each resource list page (Services, Routes, Consumers, Upstreams, etc.) duplicated the same ProTable setup, pagination handling, toolbar logic, page header, and empty-state behavior. This duplication made maintenance harder and increased the risk of inconsistencies.

With this change:

  • Common list-page logic is centralized in ResourceListPage
  • Resource pages now only define resource-specific columns and hooks
  • UI behavior, DOM structure, and user experience remain unchanged
  • Future list-page updates can be applied in a single place

Additionally, this PR improves E2E test stability by tightening selectors, improving cross-platform path handling, and reducing flakiness during parallel execution.

Why this change is needed

  • Reduces duplicated boilerplate across multiple pages
  • Improves long-term maintainability
  • Keeps list-page behavior consistent across the dashboard
  • Improves test reliability without changing functionality

Checklist

  • UI refactor only (no API or behavior changes)
  • Backward compatible
  • Lint passed
  • Build passed
  • E2E tests passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant