-
Notifications
You must be signed in to change notification settings - Fork 599
feat: add global copy ID button to all resources #3309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,22 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| apisix: | ||
| node_listen: 9080 # APISIX listening port | ||
| node_listen: 9080 | ||
| enable_ipv6: false | ||
| proxy_mode: http&stream | ||
| stream_proxy: | ||
| tcp: | ||
| - 9100 | ||
| udp: | ||
| - 9200 | ||
|
|
||
| deployment: | ||
| admin: | ||
| allow_admin: # https://nginx.org/en/docs/http/ngx_http_access_module.html#allow | ||
| - 0.0.0.0/0 # We need to restrict ip access rules for security. 0.0.0.0/0 is for test. | ||
|
|
||
| allow_admin: | ||
| - 0.0.0.0/0 | ||
| admin_key: | ||
| - name: "admin" | ||
| - name: admin | ||
| key: edd1c9f034335f136f87ad84b625c8f1 | ||
| role: admin # admin: manage all configuration data | ||
|
|
||
| role: admin | ||
| etcd: | ||
| host: # it's possible to define multiple etcd hosts addresses of the same etcd cluster. | ||
| - "http://etcd:2379" # multiple etcd address | ||
| prefix: "/apisix" # apisix configurations prefix | ||
| timeout: 30 # 30 seconds | ||
| host: | ||
| - http://etcd:2379 | ||
| prefix: /apisix | ||
| timeout: 30 |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -145,9 +145,7 @@ export const FormItemEditor = <T extends FieldValues>( | |||||||||||||||||||||
| trigger(props.name); | ||||||||||||||||||||||
| }} | ||||||||||||||||||||||
| onMount={(editor) => { | ||||||||||||||||||||||
| if (process.env.NODE_ENV === 'test') { | ||||||||||||||||||||||
| window.__monacoEditor__ = editor; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| window.__monacoEditor__ = editor; | ||||||||||||||||||||||
| }} | ||||||||||||||||||||||
|
Comment on lines
+161
to
163
|
||||||||||||||||||||||
| window.__monacoEditor__ = editor; | |
| }} | |
| (window as any).__monacoEditor__ = editor; | |
| }} | |
| onUnmount={(editor) => { | |
| const w = window as any; | |
| if (w.__monacoEditor__ === editor) { | |
| w.__monacoEditor__ = undefined; | |
| } | |
| }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -364,5 +364,7 @@ | |
| }, | ||
| "upstreams": { | ||
| "singular": "Upstream" | ||
| } | ||
| } | ||
| }, | ||
| "copy": "Kopieren", | ||
| "copy_success": "Erfolgreich kopiert" | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -364,5 +364,7 @@ | |
| }, | ||
| "upstreams": { | ||
| "singular": "Upstream" | ||
| } | ||
| } | ||
| }, | ||
| "copy": "Copiar", | ||
| "copy_success": "Copiado exitosamente" | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -364,5 +364,7 @@ | |
| }, | ||
| "upstreams": { | ||
| "singular": "Upstream" | ||
| } | ||
| } | ||
| }, | ||
| "copy": "Kopyala", | ||
| "copy_success": "Başarıyla kopyalandı" | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -364,5 +364,7 @@ | |
| }, | ||
| "upstreams": { | ||
| "singular": "上游" | ||
| } | ||
| } | ||
| }, | ||
| "copy": "复制", | ||
| "copy_success": "复制成功" | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uiClearMonacoEditorcurrently performs two separatepage.evaluatecalls (one to check presence, one to clear). This can be simplified into a single evaluate (attempt to clear if present and return a success flag), which reduces round-trips and makes it easier to fall back to the keyboard-based clearing when the evaluate fails.