-
Notifications
You must be signed in to change notification settings - Fork 366
fix: add more event filter across controllers #2449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends event filtering in various controllers to trigger reconciliations on both annotation changes and Secret updates.
- Adds
predicate.AnnotationChangedPredicate{}to several controllers - Introduces a Secret-type filter
predicate.NewPredicateFuncs(...)across controllers - Imports the predicate package in the gatewayproxy controller
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/controller/ingressclass_controller.go | Added annotation-change filter |
| internal/controller/ingress_controller.go | Added Secret update filter |
| internal/controller/gatewayproxy_controller.go | Imported predicate package and added Secret filter |
| internal/controller/apisixtls_controller.go | Added Secret update filter |
| internal/controller/apisixroute_controller.go | Added annotation-change filter and reformatted Watch |
| internal/controller/apisixconsumer_controller.go | Added Secret update filter |
Comments suppressed due to low confidence (1)
internal/controller/ingress_controller.go:78
- New event filtering logic for Secret updates has been introduced here; consider adding or updating unit/integration tests to ensure that Secret create/update/delete events correctly trigger reconciliation.
predicate.NewPredicateFuncs(func(obj client.Object) bool {
AlinsRan
reviewed
Jul 4, 2025
AlinsRan
approved these changes
Jul 4, 2025
Signed-off-by: ashing <[email protected]>
nic-6443
approved these changes
Jul 4, 2025
AlinsRan
pushed a commit
that referenced
this pull request
Jul 7, 2025
Signed-off-by: ashing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
In ApisixRouteController, it is necessary to watch the ingressClass to modify the changes in annotaions.
Pre-submission checklist: