Skip to content

fix: support filter endpoint when translate backend ref. #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronething merged 7 commits into from
Jul 4, 2025
Merged

fix: support filter endpoint when translate backend ref. #2451

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6cc42a7
fix: skip terminating endpoint
ronething Jul 4, 2025
ef37423
fix: r
ronething Jul 4, 2025
8f7a24b
fix: r
ronething Jul 4, 2025
b6209f6
fix: review
ronething Jul 4, 2025
24fbdc4
fix: r
ronething Jul 4, 2025
383ac9d
fix: r
ronething Jul 4, 2025
56cdb69
fix: r
ronething Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/provider/adc/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ func (d *adcClient) getConfigsForGatewayProxy(tctx *provider.TranslateContext, g
if !ok {
return nil, fmt.Errorf("no service found for service reference: %s", namespacedName)
}
endpoint := tctx.EndpointSlices[namespacedName]
if endpoint == nil {
endpoints := tctx.EndpointSlices[namespacedName]
if len(endpoints) == 0 {
return nil, nil
}
upstreamNodes, err := d.translator.TranslateBackendRef(tctx, gatewayv1.BackendRef{
Expand Down
8 changes: 8 additions & 0 deletions internal/provider/adc/translator/httproute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,14 @@ func (t *Translator) translateEndpointSlice(portName *string, weight int, endpoi
}
for _, endpoint := range endpointSlice.Endpoints {
for _, addr := range endpoint.Addresses {
if endpoint.Conditions.Ready != nil && !*endpoint.Conditions.Ready {
log.Debugw("skip not ready endpoint", zap.Any("endpoint", endpoint))
continue
}
if endpoint.Conditions.Terminating != nil && *endpoint.Conditions.Terminating {
log.Debugw("skip terminating endpoint", zap.Any("endpoint", endpoint))
continue
}
Copy link
Contributor

@dspo dspo Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to put the filter in the controller layer and not manage the status of k8s resources in the translation layer.
https://github.com/apache/apisix-ingress-controller/blob/master/internal/controller/utils.go#L1447

node := adctypes.UpstreamNode{
Host: addr,
Port: int(*port.Port),
Expand Down
Loading