fix: traffic-split weight distribution and add e2e tests #2495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two bugs and adds corresponding E2E tests:
backendErris currently a shared variable due to which even if one backend is invalid, no backend is set causing 0 nodes to be set on upstream even when there are valid nodes. A test case confirming the fix for this has been added. The testvalid backend is set even if other backend is invalidconfirms this fix.weightedUpstreamsdue to which all nodes always get100as weight. The tests2:1 traffic split testandzero-weight testconfirm this fix.What this PR does / why we need it:
Pre-submission checklist: