Skip to content

Conversation

@Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Jul 29, 2025

This PR solves two bugs and adds corresponding E2E tests:

  1. backendErr is currently a shared variable due to which even if one backend is invalid, no backend is set causing 0 nodes to be set on upstream even when there are valid nodes. A test case confirming the fix for this has been added. The test valid backend is set even if other backend is invalid confirms this fix.
  2. The weight from backend was not set in the upstream label which is used to set weight on weightedUpstreams due to which all nodes always get 100 as weight. The tests 2:1 traffic split test and zero-weight test confirm this fix.
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@nic-6443 nic-6443 requested review from AlinsRan and ronething July 29, 2025 09:19
Signed-off-by: Ashish Tiwari <[email protected]>
Copy link
Contributor

@ronething ronething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Revolyssup Revolyssup merged commit a35cad5 into apache:master Jul 30, 2025
24 of 26 checks passed
@Revolyssup Revolyssup deleted the revolyssup/ingress-test branch July 30, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants