chore: add test cases for external service #2500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlinsRan
reviewed
Jul 31, 2025
AlinsRan
approved these changes
Jul 31, 2025
ronething
reviewed
Jul 31, 2025
Comment on lines
+1200
to
+1204
| externalNodes: | ||
| - type: Domain | ||
| name: httpbin.org | ||
| - type: Domain | ||
| name: postman-echo.com |
Contributor
There was a problem hiding this comment.
These two services are actually not very stable. We can consider whether to replace them in the future.
Contributor
There was a problem hiding this comment.
Please refer to it and try to use local services instead of external services as they are always unstable.
Contributor
Author
There was a problem hiding this comment.
this particular test is for testing external domains other than kubernetes service.
AlinsRan
reviewed
Jul 31, 2025
| assert.True(GinkgoT(), hasEtag && hasNoEtag, "both httpbin and postman should be accessed at least once") | ||
| }) | ||
|
|
||
| It("should be able to use backends and upstreams together", func() { |
Contributor
There was a problem hiding this comment.
https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/crds/v2/route.go#L516-L545
They are very similar, I suggest integrating them into one context to avoid redundant use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pre-submission checklist: