-
Notifications
You must be signed in to change notification settings - Fork 366
refactor: E2E tests to support parallel tests #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
4842859
chore: refactor E2E tests to support parallel tests
Revolyssup c2340e5
fix ci
Revolyssup 0fe8b52
install ginkgo
Revolyssup bbadbbd
Merge branch 'master' of github.com:apache/apisix-ingress-controller …
Revolyssup f3b6bf8
fix
Revolyssup 835a81d
fix
Revolyssup d164ae8
fix
Revolyssup e7ec20a
fix ingress test
Revolyssup 26ada20
fix tls
Revolyssup 6afab7e
fix tls
Revolyssup 9dcb4ef
fix
Revolyssup 0741306
fix
Revolyssup 7b28f3b
fix ing
Revolyssup 1906033
fix ing
Revolyssup 79600b4
fix ing
Revolyssup 2f17c77
pause ingress tests
Revolyssup 91feeaf
fix consumer
Revolyssup badb102
pause defaultingress tests
Revolyssup be9929a
fix
Revolyssup 4f3edb0
fix lint
Revolyssup c3f8dbb
fix lint
Revolyssup 7e0c971
fix
Revolyssup 0ab4fdc
fix
Revolyssup 19cd878
fix
Revolyssup 8f33813
fix lint
Revolyssup 7b35de6
fix status
Revolyssup 0b229bb
increase timeout
Revolyssup a9aee63
pause httproute test
Revolyssup 4130ac0
run httproute serially
Revolyssup 05b989c
fix lint and separate out httproute tests
Revolyssup 1c58561
run 32 tests only
Revolyssup 904e129
Merge branch 'master' of github.com:apache/apisix-ingress-controller …
Revolyssup 8f7c181
rm
Revolyssup a1e5974
reduce tests
Revolyssup f11b3c7
use unique gatewayproxy name
Revolyssup 513f255
increase time for accepting
Revolyssup 6bce11a
increase gap between rq to api server
Revolyssup c975b1d
add sleep
Revolyssup fd76b09
fix controllername in httproute test
Revolyssup 67caaf3
run all tests
Revolyssup 6279ee5
fix route.go
Revolyssup e8bff71
add sleep in crd
Revolyssup 940fe22
run only failed tests
Revolyssup 17e3faf
fix
Revolyssup 6b6dc55
fix long name
Revolyssup 30ba121
run only failing tests
Revolyssup 76d080f
fix
Revolyssup cfef33d
only wait for pod when non zero replica
Revolyssup 3c21b08
tunnel only when replica>0
Revolyssup 9339785
remove redundant file
Revolyssup 6d5f7f2
fix
Revolyssup a67d6b5
fix
Revolyssup f0b1b01
decrease timeout at places and enable standalone tests
Revolyssup fcef3fd
use 4 nodes
Revolyssup dcad5b1
add label filter
Revolyssup 9bb7169
remove sleep
Revolyssup d327d42
remove pause from tests
Revolyssup 8ff0cb4
remove redundant createresourcefromstringwithnamespace
Revolyssup fc3f4c0
apply copilot suggestion
Revolyssup 470c6eb
apply suggestions
Revolyssup 89646cc
apply sug
Revolyssup 6375c58
Revert "apply sug"
Revolyssup 6e579f1
Revert "apply suggestions"
Revolyssup 9c1babf
use make install-ginkgo
Revolyssup f73fffb
increase timeout
Revolyssup 9b715d0
increase timeout
Revolyssup cd7034b
Merge branch 'master' of github.com:apache/apisix-ingress-controller …
Revolyssup 097efb1
use default scaffold
Revolyssup c4eb985
apply suggestions
Revolyssup c856c8f
revert default scaffold
Revolyssup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be used as the default behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already has default behavior:
https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/scaffold/apisix_deployer.go#L69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revered to defaultscaffold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reverted back to this behavior. I see a lot of tests fail when defaultScaffold is used. I am looking into the reason but for now I have reverted to this.