chore: add e2e test for apisixupstream with invalid ingressclass #2516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlinsRan
reviewed
Aug 19, 2025
| Expect(err).ShouldNot(HaveOccurred(), "verify ApisixRoute works") | ||
|
|
||
| By("apply apisixupstream") | ||
| applier.MustApplyAPIv2(types.NamespacedName{Namespace: s.Namespace(), Name: "httpbin-service-e2e-test"}, |
Contributor
There was a problem hiding this comment.
It checks whether the status is true, but the expectation is that the status is not updated.
I'm working on this issue. Let's hold off on merging for now.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of
apisix-ingress-controller/test/e2e/suite-ingress/suite-ingress-features/ingress-class.go
Line 85 in d3f8ce9
What this PR does / why we need it:
Pre-submission checklist: