fix: support tlsSecret from http.backends in ApisixRoute #2518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlinsRan
reviewed
Aug 21, 2025
| } | ||
| } else { | ||
| tc.Upstreams[serviceNN] = &au | ||
| if err = r.processExternalNodes(ctx, tc, au); err != nil { |
Contributor
There was a problem hiding this comment.
The backend uses Kubernetes services for service discovery, which should not allow custom endpoints. I don't think this needs to be handled.
Revolyssup
changed the title
ronething
reviewed
Aug 21, 2025
| time.Sleep(6 * time.Second) | ||
| services, err := s.DefaultDataplaneResource().Service().List(context.Background()) | ||
| Expect(err).ShouldNot(HaveOccurred(), "list services") | ||
| service := services[0] |
Contributor
There was a problem hiding this comment.
Directly accessing services[0] may result in unexpected errors leading to panic. Perhaps we can consider adding a HaveLen check before this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2496
What this PR does / why we need it:
Pre-submission checklist: