fix: hmac-auth plugin spec compatibility with latest apisix#2528
Merged
Revolyssup merged 9 commits intoapache:masterfrom Aug 28, 2025
Merged
fix: hmac-auth plugin spec compatibility with latest apisix#2528Revolyssup merged 9 commits intoapache:masterfrom
Revolyssup merged 9 commits intoapache:masterfrom
Conversation
AlinsRan
requested changes
Aug 27, 2025
Contributor
There was a problem hiding this comment.
This change introduces a breaking change.
When using older versions of the data plane, this API still applies.
Instead of removing the existing field directly, we should mark it as deprecated and clearly document the incompatibility, so that users have a migration path. Meanwhile, we can introduce the new field to support the latest data plane.
AlinsRan
approved these changes
Aug 28, 2025
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hmac-auth plugin in APISIX had gone through a rewrite/refactor due to which it's incompatible with current version of ingress controller. This PR makes it compatible with apache/apisix#11581
Now if users want to configure these fields, they will have to use PluginConfig resource with ApisixRoute aur the
pluginsfield.Key changes:
key_idandsecret_keyall fields deprecated from consumer configuration.access_keyadded along withkey_id. One of these will have to be passedWhat this PR does / why we need it:
Pre-submission checklist: