Skip to content

Conversation

@Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Aug 26, 2025

The hmac-auth plugin in APISIX had gone through a rewrite/refactor due to which it's incompatible with current version of ingress controller. This PR makes it compatible with apache/apisix#11581

Now if users want to configure these fields, they will have to use PluginConfig resource with ApisixRoute aur the plugins field.

Key changes:

  • Other than key_id and secret_key all fields deprecated from consumer configuration.
  • access_key added along with key_id. One of these will have to be passed
  • The older configuration will still be supported.
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Copy link
Contributor

@AlinsRan AlinsRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a breaking change.
When using older versions of the data plane, this API still applies.
Instead of removing the existing field directly, we should mark it as deprecated and clearly document the incompatibility, so that users have a migration path. Meanwhile, we can introduce the new field to support the latest data plane.

@Revolyssup Revolyssup requested review from AlinsRan and bzp2010 August 28, 2025 06:00
Copy link
Contributor

@ronething ronething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Revolyssup Revolyssup merged commit 06981b1 into apache:master Aug 28, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants