feat: add webhook server #2566
Merged
feat: add webhook server #2566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 283 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 190 | 1 | 92 | 0 |
Click to see the invalid file list
- test/e2e/e2e_test.go
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
There was a problem hiding this comment.
license-eye has totally checked 287 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 191 | 2 | 94 | 0 |
Click to see the invalid file list
- internal/manager/webhooks.go
- test/e2e/e2e_test.go
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
Signed-off-by: Ashing Zheng <[email protected]>
AlinsRan
reviewed
Sep 22, 2025
test/e2e/scaffold/k8s.go
Outdated
| failurePolicy: Fail | ||
| sideEffects: None | ||
| admissionReviewVersions: ["v1"] | ||
| `, s.Namespace(), s.Namespace(), base64.StdEncoding.EncodeToString(caCert.Bytes())) |
Contributor
There was a problem hiding this comment.
It may need frequent modifications, how about putting it in a file?
AlinsRan
approved these changes
Sep 22, 2025
Signed-off-by: Ashing Zheng <[email protected]>
There was a problem hiding this comment.
license-eye has totally checked 290 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 193 | 1 | 96 | 0 |
Click to see the invalid file list
- test/e2e/framework/manifests/webhook.yaml
Signed-off-by: Ashing Zheng <[email protected]>
Revolyssup
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Added webhook server feature, so that validation can be performed before the resources are actually written to the k8s cluster. The yaml resource files in the
config/directory of this PR are automatically generated bykubebuilderand are only for reference.Currently, this PR has implemented a warning handling for Annotations that are not supported by
Ingressresources.Pre-submission checklist: