fix: ensure upstream scheme is set only if not already defined in HTT… #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P route translation
Contributor
|
please merge master branch to this branch for resolving the CI error. |
ronething
approved these changes
Jan 16, 2026
Contributor
|
please also describe what bug does this fix |
Contributor
Author
@shreemaan-abhishek The description has been supplemented. |
AlinsRan
approved these changes
Jan 16, 2026
shreemaan-abhishek
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…P route translation
Type of change:
What this PR does / why we need it:
Just like what ingress translate does, it fixes the issue where httproute's schema is reset by appProtocolToUpstreamScheme after being obtained in translateBackendRef.
https://apisix.apache.org/zh/docs/ingress-controller/getting-started/load-balancing/
When testing with the above example, I found that the schema generated by ADC is http, but what is actually desired is https, and the Gateway API HTTPRoute is being used.
Pre-submission checklist: