chore: log when kubernetes cluster version does not meet minimum requirement #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashing Zheng <axingfly@gmail.com>
Signed-off-by: Ashing Zheng <axingfly@gmail.com>
Signed-off-by: Ashing Zheng <axingfly@gmail.com>
nic-6443
reviewed
Jan 6, 2026
AlinsRan
requested review from
juzhiyuan and
kayx23
and removed request for
juzhiyuan
AlinsRan
reviewed
Jan 6, 2026
internal/manager/run.go
Outdated
| } | ||
|
|
||
| func checkK8sVersion(mgr ctrl.Manager, logger logr.Logger) { | ||
| const minVersion = "1.26.0" |
Contributor
There was a problem hiding this comment.
Maybe we can pass parameters during code compilation. What do you think? Similar to version.
AlinsRan
approved these changes
Jan 6, 2026
nic-6443
approved these changes
Jan 7, 2026
kayx23
approved these changes
Jan 7, 2026
Contributor
Author
|
Test cases that cause errors are not within the scope of local modifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Optimize the ingress documentation and clearly inform the reasons for relying on the 1.26+ cluster version
When ingress starts and detects that the cluster version does not meet the requirements, it prints a warning log to alert the user
Pre-submission checklist: