Skip to content

fix: disable dashboard next version doc config #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

fix: disable dashboard next version doc config #1915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/docusaurus.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ module.exports = {
path: 'docs/apisix-dashboard',
showLastUpdateAuthor: true,
showLastUpdateTime: true,
includeCurrentVersion: false,
Copy link
Preview

Copilot AI May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an explanatory comment for disabling includeCurrentVersion would clarify that this setting is necessary to render the documentation site properly as a temporary measure.

Copilot uses AI. Check for mistakes.

routeBasePath: '/docs/dashboard',
sidebarPath: require.resolve('./docs/apisix-dashboard/sidebars.json'),
editUrl(props) {
Expand Down
1 change: 1 addition & 0 deletions scripts/sync-docs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ const tasks = new Listr([
},
{
title: `Extract ${project.name} next version documents`,
skip: () => project.name === 'apisix-dashboard',
Copy link
Preview

Copilot AI May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an inline comment to explain why the extraction is skipped for apisix-dashboard, referencing the temporary solution from the linked review.

Copilot uses AI. Check for mistakes.

task: () => extractDocsNextVersionTasks(project, project.branch),
},
]),
Expand Down
Loading