Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the documentation build process and add manual triggering capability through GitHub Actions. Key changes include creating an empty sidebars.json for the APISIX Dashboard docs and adding a workflow_dispatch trigger to the deploy workflow.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| doc/docs/apisix-dashboard/sidebars.json | Adds a new JSON configuration file for dashboard documentation. |
| .github/workflows/deploy.yml | Introduces manual triggering via workflow_dispatch with branch input. |
Comments suppressed due to low confidence (1)
.github/workflows/deploy.yml:18
- The workflow default branch is set to 'master'. If your repository default is 'main' or follows a different naming convention, consider updating this value to avoid confusion.
default: 'master'
juzhiyuan
approved these changes
May 17, 2025
bzp2010
approved these changes
May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #[Add issue number here]
Changes:
Screenshots of the change:
Fix https://github.com/apache/apisix-website/actions/runs/15066615081/job/42352784489. Performed a complete reset locally, installed dependencies, and rebuilt the site to test again.
Also add a
workflow_dispatchto help us manually trigger a build to check for issues.