Fix: Add accessible titles to comparison table icons#1985
Open
huangkevin-apr wants to merge 1 commit intoapache:masterfrom
Open
Fix: Add accessible titles to comparison table icons#1985huangkevin-apr wants to merge 1 commit intoapache:masterfrom
huangkevin-apr wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds accessibility improvements to the comparison table on the Apache APISIX website by providing accessible titles to checkmark and cross icons. The change addresses WCAG 2.1 Level A compliance issues (Success Criterion 1.1.1 - Non-text Content) identified by IBM Equal Access Accessibility Checker, ensuring screen reader users can understand feature support status in the comparison table.
Changes:
- Added descriptive
titleprops to all<Tick>and<Cross>SVG components in the comparison table - Tick icons now announce "Supported" to screen readers
- Cross icons now announce "Not supported" to screen readers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1984
Changes:
Solution
Added descriptive
titleprops to all<Tick>and<Cross>components in the comparison table:<Tick title="Supported" />- Clearly indicates the feature is supported in APISIX<Cross title="Not supported" />- Clearly indicates the feature is not supported in other API gatewaysChanges Made
Files Modified:
website/src/components/sections/Comparison.tsxDetailed Changes:
1. Dubbo, MQTT, Tengine and REST API to gRPC transcoding
2. Configuration rollback
3. Custom Load Balancing and routing
4. Plugin hot loading
5. Dashboard
6. Support any NGINX variable as routing condition
Screenshots of the change:
Fix Before

Fix After

Additional Info
The patch submitted in this PR was generated by A11YRepair, an automated Web Accessibility repair tool that I developed to address common accessibility violations in web applications.
The generated fixes were manually reviewed and validated before submission.