fix: the health checker can't be released due to the health parent being released early #11760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
Revolyssup
changed the title
moonming
approved these changes
Nov 21, 2024
nic-chen
approved these changes
Nov 22, 2024
shreemaan-abhishek
approved these changes
Nov 22, 2024
…kport/health-checker-leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client requests, if the currently hit route or the corresponding upstream changes again, APISIX will try to re-create the health check checker for the upstream of the currently hit route and release the original health check checker.
During the process of re-creating the health check checker, when each upstream node is added as the target of the health check, the locking operation may take a long time to execute.
If the process of creating a health check checker is relatively long, and the route or the corresponding upstream changes at the same time, the parent of the upstream has been released, and in the previous step, the re-created healthcheck checker will be added to an empty object (the original intention is to Added to the new upstream parent), the checker can't be released, resulting in an "orphan" checker, which always performs health checks on the old nodes.