Skip to content

feat: add support for "system" ssl_trusted_certificate #11809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moonming merged 4 commits into from
Dec 9, 2024
Merged

feat: add support for "system" ssl_trusted_certificate #11809

moonming merged 4 commits into from
Dec 9, 2024

Conversation

@Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Dec 4, 2024 •
edited
Loading

Description

Fixes # (issue)
With this feature, users can set system as the value to use when ca_certs are to be used from the system defined ca certs.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Dec 4, 2024
membphis
membphis approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moonming moonming merged commit aaad8ba into apache:master Dec 9, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@membphis membphis membphis approved these changes

@moonming moonming moonming approved these changes

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@nic-6443 nic-6443 Awaiting requested review from nic-6443

Assignees

No one assigned

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Revolyssup @membphis @moonming @shreemaan-abhishek