feat(ip-restriction): support 404 response code#12076
Merged
Baoyuantop merged 1 commit intoapache:masterfrom Mar 26, 2025
Merged
feat(ip-restriction): support 404 response code#12076Baoyuantop merged 1 commit intoapache:masterfrom
Baoyuantop merged 1 commit intoapache:masterfrom
Conversation
dosubot
bot
added
size:L
Contributor
Author
|
I think making response code configurable to 404 is enough. Should we support any response codes, or any 4xx codes? |
Contributor
|
Personally I think any 4xx code should be configurable, looking forward to other more comments. |
moonming
approved these changes
Mar 25, 2025
Baoyuantop
approved these changes
Mar 25, 2025
membphis
approved these changes
Mar 26, 2025
laz-xyr
pushed a commit
to laz-xyr/apisix
that referenced
this pull request
Jun 19, 2025
Co-authored-by: papdaniel <papfdani@gmailcom>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support 404 response code to hide the route from blacklisted/not whitelisted sources
Fixes #12056
Checklist