Skip to content

fix: plugin not add args, original args will lost #12287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: plugin not add args, original args will lost #12287

wants to merge 6 commits into from
+567 −6

Conversation

wanglihui
Copy link

@wanglihui wanglihui commented Jun 4, 2025 •
edited
Loading

Description

Which issue(s) this PR fixes:

Fixes ##12240

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 4, 2025
@Baoyuantop
Copy link
Contributor

Hi @wanglihui, need add test case.

@Baoyuantop Baoyuantop linked an issue Jun 13, 2025 that may be closed by this pull request
bug: ext-plugin process rewrite:args logic error #12240
Open
@Baoyuantop
Copy link
Contributor

Hi @wanglihui, are you still working on this PR?

@Baoyuantop Baoyuantop marked this pull request as draft June 24, 2025 07:18
@Baoyuantop Baoyuantop added the wait for update wait for the author's response in this issue/PR label Jul 3, 2025
@wanglihui wanglihui marked this pull request as ready for review July 31, 2025 09:57
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 31, 2025
@SkyeYoung SkyeYoung changed the title fix: plugin not add args, original args will lost bug#12286 fix: plugin not add args, original args will lost Aug 12, 2025
@SkyeYoung
Copy link
Member

Pls fix the CI.

@SkyeYoung
Copy link
Member

@wanglihui anyupdate?

@github-actions GitHub Actions
Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working size:XL This PR changes 500-999 lines, ignoring generated files. stale wait for update wait for the author's response in this issue/PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: ext-plugin process rewrite:args logic error

3 participants

@wanglihui @Baoyuantop @SkyeYoung