Skip to content

Conversation

@Crazy-xyr
Copy link
Contributor

@Crazy-xyr Crazy-xyr commented Sep 22, 2025

Description

plugin.enable_data_encryption does not initialization when no plugin configuration for routes, plugin_metadata, etc,When not initialized, querying non-existent plugin_metadata via the admin_api will report http 500
Just like encrypt_conf and decrypt_conf, Instead of directly accessing plugin.enable_data_encryption, call the method enable_gde(),decrypt_params metadata is changed to the same code style as node and list to avoid nil

Which issue(s) this PR fixes:

Fixes #12618

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Sep 22, 2025
@Crazy-xyr Crazy-xyr changed the title Fixes(plugin_metadata): Ensure enable_data_encryption initialization + Querying issue Fix(plugin_metadata): Ensure enable_data_encryption initialization + Querying issue Sep 22, 2025
@Crazy-xyr Crazy-xyr changed the title Fix(plugin_metadata): Ensure enable_data_encryption initialization + Querying issue fix(plugin_metadata): Ensure enable_data_encryption initialization + Querying issue Sep 22, 2025
@Crazy-xyr
Copy link
Contributor Author

Crazy-xyr commented Sep 22, 2025

@Baoyuantop fix ci error,when merging the upstream, due to this pr #12603, no longer populates default values when writing, rename node.name to id to avoid decryption failure

@Crazy-xyr
Copy link
Contributor Author

@Baoyuantop CI Tars Need I fix it?

@Baoyuantop
Copy link
Contributor

@Baoyuantop CI Tars Need I fix it?

This seems unrelated to this PR. I'll start reviewing this PR when I have free time.

@Baoyuantop Baoyuantop self-requested a review September 25, 2025 08:38
@Baoyuantop Baoyuantop changed the title fix(plugin_metadata): Ensure enable_data_encryption initialization + Querying issue fix(plugin_metadata): ensure enable_data_encryption initialization & querying issue Oct 29, 2025
@Baoyuantop
Copy link
Contributor

Hi @Crazy-xyr, there is still a failed CI, we can merge the main branch code and try again.

@Crazy-xyr
Copy link
Contributor Author

@Baoyuantop My local repository ci checks all pass, but pr always has some tests failing. Can you retry only the failed tests
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

bug: 500 Internal Server Error when querying non-existent plugin metadata via Admin API

4 participants