Skip to content

docs: update powered-by.md #12643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: update powered-by.md #12643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions powered-by.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ Users are encouraged to add themselves to this page, [issue](https://github.com/
1. <a href="https://www.jpl.nasa.gov" rel="nofollow">NASA JPL 美国国家航空航天局 喷气推进实验室</a>
1. <a href="https://www.purcotton.com/" rel="nofollow">Purcotton 深圳全棉时代科技有限公司</a>
1. <a href="https://www.360.cn/" rel="nofollow">360 奇虎</a>
1. <a href="https://marmelab.com/react-admin/AuthProviderList.html" rel="nofollow">React-admin</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this page is supposed to mean. Why isn't it the homepage?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what to link... React-admin is a frontend framework for building B2B applications with React. It works with data providers to plug the admin to an api, and auth providers to plug the admin to whatever can handle authentication. One of the Auth-providers is @arte/ra-apisix-oidc that allows you to use apisix authentication.

So as I found that linking to React-admin homepage would be confusing, I choosed to link to the documentation refering to the authProvider list, where you can see the Apisix one.

Is it clearer and does it seems relevant ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the relevance here. I'll wait for other maintainers' opinions.

1. <a href="http://www.sinog2c.com/" rel="nofollow">sinog2c 湖南国科云通</a>
1. <a href="https://www.sinovatech.com" rel="nofollow">sinovatech 炎黄新星</a>
1. <a href="http://taikang.com/" rel="nofollow">Taikanglife 泰康云</a>
Expand Down