refactor(improvement): use secret URI as key for cache and refactor lrucache #12682
+379
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Revolyssup
changed the title
nic-6443
reviewed
Oct 18, 2025
|
|
||
|
|
||
| local function fetch_by_uri(secret_uri) | ||
| local function fetch_by_uri_secret(secret_uri) |
There was a problem hiding this comment.
I am using a new local function with same name here https://github.com/apache/apisix/pull/12682/files#diff-50c5241a560560f8d61637b60caa3e9f2dce27139863265cfa8ffb63a8537803R212 so this function name got changed to be more specific to avoid conflict.
nic-6443
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secret module changes: Currently the cache key is the whole conf which is inefficient because multiple conf might be referencing the same secret.
So new requirement is to refactor apisix/secret.lua so that cache key is the url and we only cache the result of fetch(uri) function.
LRUCache module changes: Allow LRU cache to have different underlying cache for success and failure, so that each of them can be configured differently.
NOTE: The fetch_secrets() API is simplified to not take key and version from the caller because they were redundant anyways and moreover now the key is resolved internally.
Checklist