Skip to content

Conversation

@shreemaan-abhishek
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek commented Jan 1, 2026

Description

When skywalking is enabled but plugin_attr is not configured, the default skywalking endpoint_addr is taken into affect and error logs may be continuously printed as that endpoing may not be available by default. This behaviour is annoying and unnecessary.

So this PR introduces a change that starts the timer that performs reporting only after a route configuring skywalking plugin is hit instead of starting it directly when the plugin is initialised during startup.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek shreemaan-abhishek changed the title fix(skywalking): start timer when routing is hit fix(skywalking): start timer when route is hit Jan 2, 2026
Signed-off-by: Abhishek Choudhary <[email protected]>
@shreemaan-abhishek shreemaan-abhishek marked this pull request as ready for review January 2, 2026 04:27
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant