build(python): Use meson-python for adbc_driver_manager #2759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Apr 29, 2025
| # hack until https://github.com/mesonbuild/wrapdb/pull/2072 | ||
| backward_incdir = include_directories('subprojects/backward-cpp-1.6') | ||
|
|
||
| adbc_driver_manager_dep = dependency( |
Contributor
Author
There was a problem hiding this comment.
The idea here is that Meson can look for adbc-driver-manager through its typical its typical search mechanism (typically pkgconf). If it is not installed, Meson will look at subprojects/arrow-adbc, which symlinks to the C directory
One caveat to this is if a user is trying to locally develop on a system where the ADBC Driver Manager is installed, it will pick up the system dependency rather than the local one. If we wanted to prevent that we could add more logic potentially
WillAyd
force-pushed
the
meson-python
branch
6 times, most recently
from
8436a0c to
17d5426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using meson-python should help us create a more consistent Python developer experience while also easing the burden of building and packaging Python libraries with C extensions