feat(csharp/src/Apache.Arrow.Adbc): ensure tracing redacts PII#3157
Closed
birschick-bq wants to merge 12 commits intoapache:mainfrom
Closed
feat(csharp/src/Apache.Arrow.Adbc): ensure tracing redacts PII#3157birschick-bq wants to merge 12 commits intoapache:mainfrom
birschick-bq wants to merge 12 commits intoapache:mainfrom
Conversation
birschick-bq
changed the title
ryan-syed
reviewed
Jul 16, 2025
ryan-syed
reviewed
Jul 16, 2025
Contributor
Author
|
@CurtHagenlocher Let me know if you have any comments or suggestion for this PR, when you have a chance. Thanks. |
Contributor
Author
|
@CurtHagenlocher Just checking to see if you have any comments or suggestions for this PR. Thanks. |
Contributor
Author
|
@CurtHagenlocher This contains binary breaking changes. Let me know if you want me to refactor to only add new and preserve the existing implementation. Thanks. |
jduo
reviewed
Aug 11, 2025
davidhcoe
reviewed
Aug 29, 2025
davidhcoe
reviewed
Aug 29, 2025
davidhcoe
reviewed
Aug 29, 2025
Contributor
Author
|
Abandoning. Will bring something later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a wrapper class to the
Activityclass such that values traced will, by default, be redacted.To ensure the value is not redacted, the developer needs to change the
isPiiflag tofalsewhen instrumenting tracing.Likewise, the
TraceActivitymethods will by default mark any exception message as PII. Developers can use theexceptionIsPiiset tofalseto change the behavior.The
RedactedValuestructure includes theGetUnredactedValuemethod for listeners/exporters that can safely handle the unredacted PII.