fix(rust/driver_manager): modify SYSTEM path behavior on macOS #3252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ianmcook |
|
It'd be nice to factor this out into a |
|
Good point! |
|
Refactored in 8141e58. |
lidavidm
reviewed
Aug 10, 2025
lidavidm
approved these changes
Aug 12, 2025
|
I think we can rebase and merge here |
amoeba
force-pushed
the
fix/rust-driver-manager-macos-system-path
branch
from
ee11c01 to
ca75aa2
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicates the change in #3250 to the Rust Driver Manager. Follow-on to #3247
Modifies the behavior of GetSearchPaths so macOS doesn't follow other Unix-likes but instead uses the more conventional /Library/Application Support/ADBC. /etc/ isn't really a thing on macOS.
Tested manually by debugging the test with and without
/Library/Application Support/ADBCexisting and verifying the right branch gets hit. I'm not too worried exercising this in CI but we could.