Skip to content

fix(csharp/src/Drivers/Apache/Hive2): add check to see if operation is already closed #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CurtHagenlocher merged 5 commits into from
Aug 19, 2025
Merged

fix(csharp/src/Drivers/Apache/Hive2): add check to see if operation is already closed #3301

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
deaaaf5
fix(csharp/src/Drivers/Apache/Hive2): add check to see if operation i…
birschick-bq Aug 18, 2025
2db2034
fix(csharp/src/Drivers/Apache/Hive2): add check to see if operation i…
birschick-bq Aug 18, 2025
d86a58f
restored functionality to set the direct result on Databricks connection
birschick-bq Aug 18, 2025
73a1328
revert: restored functionality to set the direct result on Databricks…
birschick-bq Aug 18, 2025
3075223
revert: restored functionality to set the direct result on Databricks…
birschick-bq Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions csharp/src/Drivers/Apache/Hive2/HiveServer2Reader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,13 +429,17 @@ protected override void Dispose(bool disposing)
/// <param name="response">The response for the operation.</param>
/// <returns>The server response for the CloseOperation call.</returns>
/// <exception cref="HiveServer2Exception" />
internal static async Task<TCloseOperationResp> CloseOperationAsync(IHiveServer2Statement statement, IResponse response)
internal static async Task<TCloseOperationResp?> CloseOperationAsync(IHiveServer2Statement statement, IResponse response)
{
CancellationToken cancellationToken = ApacheUtility.GetCancellationToken(statement.QueryTimeoutSeconds, ApacheUtility.TimeUnit.Seconds);
TCloseOperationReq request = new TCloseOperationReq(response.OperationHandle!);
TCloseOperationResp resp = await statement.Client.CloseOperation(request, cancellationToken);
HiveServer2Connection.HandleThriftResponse(resp.Status, activity: null);
return resp;
if (response.DirectResults?.CloseOperation?.Status?.StatusCode != TStatusCode.SUCCESS_STATUS)
{
CancellationToken cancellationToken = ApacheUtility.GetCancellationToken(statement.QueryTimeoutSeconds, ApacheUtility.TimeUnit.Seconds);
TCloseOperationReq request = new TCloseOperationReq(response.OperationHandle!);
TCloseOperationResp resp = await statement.Client.CloseOperation(request, cancellationToken);
HiveServer2Connection.HandleThriftResponse(resp.Status, activity: null);
return resp;
}
return null;
}
}
}