fix(csharp/src/Drivers/Databricks): Update DirectResult MaxRows MaxBytes setting#3489
Merged
CurtHagenlocher merged 3 commits intoapache:mainfrom Sep 26, 2025
Merged
Conversation
eric-wang-1990
changed the title
CurtHagenlocher
requested changes
Sep 26, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! Can you please fix the linter warnings?
CurtHagenlocher
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The directResults field control how many rows/bytes can be returned in one arrow batch.
Before this change, due to a bug for databricks it is calling base class SparkConnection, which has maxRows=1000, which is too small.
ODBC can get all results in a single ExecuteStatement call while ADBC needs 1 ExecuteStatement and multiple FetchResults, which cause ADBC to be slower in small queries.
For ADBC:
For ODBC:
This PR update the DefaultMaxBytes to 10MB, which is the same limit on Databricks backend for Arrow row set.
MaxRows to be 500K, assuming a minimum 20 Bytes column size.