refactor(rust/ffi): make fields of FFI structs public#3553
Merged
lidavidm merged 1 commit intoapache:mainfrom Oct 10, 2025
Merged
refactor(rust/ffi): make fields of FFI structs public#3553lidavidm merged 1 commit intoapache:mainfrom
lidavidm merged 1 commit intoapache:mainfrom
Conversation
Member
Author
|
CC @eitsupi |
mbrobbel
reviewed
Oct 9, 2025
Member
mbrobbel
left a comment
mbrobbel
left a comment
There was a problem hiding this comment.
Instead of making all fields pub, maybe we should add methods that enable you to do what you want? With methods we can check invariants and prevent users from accidentally doing the wrong thing.
Member
Author
|
This is already the FFI/unsafe layer, though. I don't think there's value in investing into a lot of abstraction when it's not clear what abstractions (if any) are valuable |
Member
Author
|
In any case, what I'm trying to do is call methods from private_driver (and in the future, possibly patch/replace private_driver) so I expect the only thing you could do is make the fields public. |
Member
Makes sense, this should be |
mbrobbel
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3552.