-
Notifications
You must be signed in to change notification settings - Fork 179
feat(c/include/arrow-adbc): Add AdbcStatementRequestSchema #3623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paleolimbot
wants to merge
5
commits into
apache:spec-1.2.0
Choose a base branch
from
paleolimbot:spec-request-schema
base: spec-1.2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1255,6 +1255,10 @@ struct ADBC_EXPORT AdbcDriver { | |
| AdbcStatusCode (*StatementSetOptionInt)(struct AdbcStatement*, const char*, int64_t, | ||
| struct AdbcError*); | ||
|
|
||
| // ADBC 1.2 | ||
| AdbcStatusCode (*StatementRequestSchema)(struct AdbcStatement*, struct ArrowSchema*, | ||
| struct AdbcError*); | ||
|
|
||
|
||
| /// @} | ||
|
|
||
| /// \defgroup adbc-1.2.0 ADBC API Revision 1.2.0 | ||
|
|
@@ -2293,6 +2297,36 @@ AdbcStatusCode AdbcStatementExecuteSchema(struct AdbcStatement* statement, | |
| struct ArrowSchema* schema, | ||
| struct AdbcError* error); | ||
|
|
||
| /// \brief Request the schema of the next statement execution | ||
| /// | ||
| /// Allows the caller to request a specific schema based on prior | ||
| /// information or user input. This may be used to ensure a | ||
| /// consistent schema when executing queries against a database | ||
| /// with row-based types (e.g., SQLite) or a database whose types | ||
| /// are implemented with row-based parameters where Arrow prefers | ||
| /// type-level parameters (e.g., NUMERIC for PostgreSQL). | ||
| /// | ||
| /// The provided schema is a request and not a guarantee (i.e., | ||
| /// callers must use the schema provided by the output stream to | ||
| /// interpret the result). | ||
| /// | ||
| /// Calling AdbcStatementRequestSchema() must not affect the result | ||
| /// of AdbcStatementExecuteSchema (which always infers its result | ||
| /// from the input query). | ||
| /// | ||
| /// \since ADBC API revision 1.2.0 | ||
| /// | ||
| /// \param[in] statement The statement to execute. | ||
| /// \param[in] schema The requested schema. | ||
| /// \param[out] error An optional location to return an error | ||
| /// message if necessary. | ||
| /// | ||
| /// \return ADBC_STATUS_NOT_IMPLEMENTED if the driver does not support this. | ||
| ADBC_EXPORT | ||
| AdbcStatusCode AdbcStatementRequestSchema(struct AdbcStatement* statement, | ||
| struct ArrowSchema* schema, | ||
| struct AdbcError* error); | ||
|
|
||
| /// \brief Turn this statement into a prepared statement to be | ||
| /// executed multiple times. | ||
| /// | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be in a separate block that checks the version