feat(python/adbc_driver_flightsql): add constants for OAuth options #3849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xborder
changed the title
lidavidm
changed the title
lidavidm
reviewed
Jan 3, 2026
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Thanks!
These recipes won't run in CI as-is. Is there some minimal implementation that we can run them against?
Adding oauth mock server to be used for recipes. Creates a token that gets validated by a mock flight server
zeroshade
approved these changes
Jan 4, 2026
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Should we add constants in the other languages too?
Contributor
Author
|
@lidavidm I've added a mock oauth server and complementary validation on flightsql test server to make the recipes work @zeroshade Yes. Is there any other language that wraps the go driver similarly to python? If not this is a feature gap in other languages. |
Member
|
I think we can handle other languages in other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds OAuth options introduced in #2651 to python
Related Issues
Closes #2714
Changes Made