fix(c/driver/postgresql): honor GetObjects schema filter

[corleyma]

Summary

Fix the PostgreSQL driver’s GetObjects table enumeration so db_schema / db_schema_filter does not depend on search_path.

Details

The tables query used pg_catalog.pg_table_is_visible(c.oid), which is search_path-dependent and can hide tables in non-current schemas even when a schema filter is provided. Remove that predicate and rely on the explicit schema predicate.

Tests

• pre-commit run
• ctest -L driver-postgresql (against postgres-test from docker compose)

Closes #3854

[lidavidm]

Thanks!

[lidavidm]

It seems other tests leave behind some stuff that causes the new test to fail. Maybe it can be a little more forgiving?

>       assert len(metadata) == 1
E       AssertionError: assert 3 == 1
E        +  where 3 = len([{'catalog_name': 'postgres', 'catalog_db_schemas': [{'db_schema_name': 'dbapi_get_objects_test', 'db_schema_tables': [{'table_name': 'schema_filter_table', 'table_type': 'table', 'table_columns': None, 'table_constraints': None}]}]}, {'catalog_name': 'template1', 'catalog_db_schemas': []}, {'catalog_name': 'template0', 'catalog_db_schemas': []}])

[corleyma]

Pushed a follow-up commit to make the Python regression test tolerant of Postgres returning multiple catalogs (e.g., template0/template1). The test now selects the current catalog entry instead of assuming a single row.

[lidavidm]

The linter made a change 😅

 diff --git a/python/adbc_driver_postgresql/tests/test_dbapi.py b/python/adbc_driver_postgresql/tests/test_dbapi.py
index aae214275..5fe72cfa3 100644
--- a/python/adbc_driver_postgresql/tests/test_dbapi.py
+++ b/python/adbc_driver_postgresql/tests/test_dbapi.py
@@ -24,6 +24,7 @@ import numpy
 import pyarrow
 import pyarrow.dataset
 import pytest
+
 from adbc_driver_postgresql import ConnectionOptions, StatementOptions, dbapi
 
 
@@ -81,7 +82,9 @@ def test_get_objects_schema_filter_outside_search_path(
     )
 
     catalog_name = postgres.adbc_current_catalog
-    catalog = next((row for row in metadata if row["catalog_name"] == catalog_name), None)
+    catalog = next(
+        (row for row in metadata if row["catalog_name"] == catalog_name), None
+    )
     assert catalog is not None
 
     schemas = catalog["catalog_db_schemas"]

[corleyma]

Re-ran the CI-style flow locally (Ubuntu container + compose postgres-test): ci/scripts/python_build.sh then PYTEST_ADDOPTS=--error-for-skips ci/scripts/python_test.sh with only BUILD_DRIVER_POSTGRESQL=1. Result: 30 passed (includes the new test_get_objects_schema_filter_outside_search_path).