Skip to content

GH-46087: [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeroshade merged 3 commits into from
May 2, 2025
Merged

GH-46087: [FlightSQL] Allow returning column remarks in FlightSQL's CommandGetTables #361

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c82faea
GH-46087: [FlightSQL] Allow returning column remarks in FlightSQL's C…
mateuszrzeszutek Apr 24, 2025
f1dce07
add integration tests changes
mateuszrzeszutek Apr 27, 2025
7a13048
spaces -> tabs
mateuszrzeszutek Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions arrow/flight/flightsql/column_metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ const (
IsCaseSensitiveKey = "ARROW:FLIGHT:SQL:IS_CASE_SENSITIVE"
IsReadOnlyKey = "ARROW:FLIGHT:SQL:IS_READ_ONLY"
IsSearchableKey = "ARROW:FLIGHT:SQL:IS_SEARCHABLE"
RemarksKey = "ARROW:FLIGHT:SQL:REMARKS"
)

// ColumnMetadata is a helper object for managing and querying the
Expand Down Expand Up @@ -130,6 +131,10 @@ func (c *ColumnMetadata) IsSearchable() (bool, bool) {
return c.findBoolVal(IsSearchableKey)
}

func (c *ColumnMetadata) Remarks() (string, bool) {
return c.findStrVal(RemarksKey)
}

// ColumnMetadataBuilder is a convenience builder for constructing
// sql column metadata using the expected standard metadata keys.
// All methods return the builder itself so it can be chained
Expand Down Expand Up @@ -215,3 +220,9 @@ func (c *ColumnMetadataBuilder) IsSearchable(v bool) *ColumnMetadataBuilder {
c.vals = append(c.vals, boolToStr(v))
return c
}

func (c *ColumnMetadataBuilder) Remarks(remarks string) *ColumnMetadataBuilder {
c.keys = append(c.keys, RemarksKey)
c.vals = append(c.vals, remarks)
return c
}