Skip to content

GH-759: Get length of byte[] in TryCopyLastError #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 10 commits into from
Jul 1, 2025
Merged

GH-759: Get length of byte[] in TryCopyLastError #760

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c3ad74d
fix get length of byte[]
hnwyllmm May 20, 2025
a4614c5
add a unittest
hnwyllmm May 25, 2025
8d2c4d5
test copy-error
hnwyllmm May 31, 2025
4f158ee
test for copyerror
hnwyllmm Jun 2, 2025
ee860b1
remove unused file
hnwyllmm Jun 2, 2025
88ed36b
shorten exception message
hnwyllmm Jun 2, 2025
3f40711
assert throws
hnwyllmm Jun 7, 2025
cd9cd5b
simplify message test
hnwyllmm Jun 8, 2025
d6ea33e
fix checkstyle
hnwyllmm Jun 30, 2025
2d71582
fix spotless
hnwyllmm Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion c/src/main/cpp/jni_wrapper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,9 @@ void TryCopyLastError(JNIEnv* env, InnerPrivateData* private_data) {
return;
}

jsize error_bytes_len = env->GetArrayLength(arr);
char* error_str = reinterpret_cast<char*>(error_bytes);
private_data->last_error_ = std::string(error_str, std::strlen(error_str));
private_data->last_error_ = std::string(error_str, error_bytes_len);

env->ReleaseByteArrayElements(arr, error_bytes, JNI_ABORT);
}
Expand Down
Loading