chore: Remove unnecessary use of __COUNTER__#853
Open
paleolimbot wants to merge 2 commits intoapache:mainfrom
Open
chore: Remove unnecessary use of __COUNTER__#853paleolimbot wants to merge 2 commits intoapache:mainfrom
__COUNTER__#853paleolimbot wants to merge 2 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
- Coverage 79.96% 79.84% -0.13%
==========================================
Files 105 106 +1
Lines 15461 15633 +172
Branches 1738 1742 +4
==========================================
+ Hits 12364 12482 +118
- Misses 1998 2051 +53
- Partials 1099 1100 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paleolimbot
commented
Mar 5, 2026
| matrix: | ||
| config: | ||
| - {os: macOS-latest, r: 'release'} | ||
| - {os: windows-latest, r: '4.1'} |
Member
Author
There was a problem hiding this comment.
The action we were using to install R no longer supports R 4.1 (released in 2021), so I think we can drop official support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In apache/arrow-adbc#4044, ADBC has to work around a clang warning that declares
__COUNTER__an extension. We don't strictly need it here so I just removed the usage. Claude Opus seems to think this is safe because of thedo { ... } while(0);scoping but alternative opinions are welcome!