Skip to content

Conversation

lilianm
Copy link
Contributor

@lilianm lilianm commented Sep 1, 2025

Which issue does this PR close?

Rationale for this change

Add same API between sync and async API

What changes are included in this PR?

There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.

Are these changes tested?

Add test_async_arrow_group_writer

Are there any user-facing changes?

Yes, add two public function get_column_writers, append_row_group for AsyncArrowWrite

@github-actions github-actions bot added the parquet Changes to the parquet crate label Sep 1, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks (again) for this contribution @lilianm -- it looks great. I think it just needs one more test.

@lilianm lilianm force-pushed the parquet_async_writer_row_group branch from 57a9e2a to 51c3881 Compare September 5, 2025 10:15
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @lilianm -- this now looks good to me

@lilianm lilianm force-pushed the parquet_async_writer_row_group branch from 51c3881 to 2ad03f7 Compare September 5, 2025 14:01
@alamb alamb merged commit bffad59 into apache:main Sep 5, 2025
16 checks passed
@alamb
Copy link
Contributor

alamb commented Sep 5, 2025

Thanks again @lilianm and @mbrobbel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Parquet] Add row group write with AsyncArrowWriter
3 participants