[Variant] Benchmark for shred_variant kernels#8394
Draft
alamb wants to merge 1 commit intoapache:mainfrom
Draft
Conversation
3015096 to
731ca22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft because it needs additional shredding support (for Utf8 and timestamp, for example)
Which issue does this PR close?
Rationale for this change
I would like to make sure
variant_shredis super fast and the first part of that is benchmarking itWhat changes are included in this PR?
Add a benchmark
Run it like this
Are these changes tested?
I ran it manually and it is tested by clippy in by CI
Are there any user-facing changes?
No