Avoid a clone when creating DictionaryArray from ArrayData
#9185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jan 15, 2026
| key_data_type | ||
| ); | ||
|
|
||
| let values = make_array(data.child_data()[0].clone()); |
Contributor
Author
There was a problem hiding this comment.
saves a clone here of both the child data and also a DataType::Drop
alamb
commented
Jan 15, 2026
| .child_data(vec![]) | ||
| .build_unchecked() | ||
| }); | ||
| let keys = PrimitiveArray::<T>::new(ScalarBuffer::new(buffer, offset, len), nulls); |
Contributor
Author
There was a problem hiding this comment.
Bonus removal of unsafe
Draft
1 task
Contributor
|
Looks good! |
Dandandan
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
make_array) #9061ArrayData(speed up reading from Parquet reader) #9058Rationale for this change
Let's make arrow-rs the fastest we can and the fewer allocations the better
What changes are included in this PR?
Apply pattern from #9114
Are these changes tested?
Existing tests
Are there any user-facing changes?
No