arrow-flight: generate dict_ids for dicts nested inside complex types#9556
Open
asubiotto wants to merge 1 commit intoapache:mainfrom
Open
arrow-flight: generate dict_ids for dicts nested inside complex types#9556asubiotto wants to merge 1 commit intoapache:mainfrom
asubiotto wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
cc @brancz |
Some cases were missing. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
3393972 to
670d9ad
Compare
brancz
approved these changes
Mar 14, 2026
Contributor
|
cc @alamb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cases were missing.
Which issue does this PR close?
Rationale for this change
Fix flight encoding panic
What changes are included in this PR?
Assigning dict ids properly to nested dicts
Are these changes tested?
Yes. The same tests fail on main.
Are there any user-facing changes?