Skip to content

Conversation

chenyuan99
Copy link

@chenyuan99 chenyuan99 commented Sep 18, 2025

What's Changed

We can refer Swift Package Index because we've released a new version and registered to Swift Package Index.

Closes #86.

@kou kou changed the title #86 update readme to reflect changes after the publish to Swift Packa… chore: Use Swift Package Index for how to install and documentation Sep 18, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that we need these configurations to generate documentation on Swift Package Index and we can't refer generated documentation after our next release?

If so, could you split the "adding support for documentation generation on Swift Package Index" changes and the "update README" changes to separated PRs?

We'll work on the former BEFORE we release a new version and work on the later changes AFTER we release a new version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## Install

TODO: We should update this after we register this package to Swift Package Index.
[![Swift Package Index](https://swiftpackageindex.com/apache/arrow-swift/badge.swift)](https://swiftpackageindex.com/apache/arrow-swift)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this badge URL is 404: https://swiftpackageindex.com/apache/arrow-swift/badge.swift

Could you check it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: We should update this after we register this package to Swift Package Index.
[![Swift Package Index](https://swiftpackageindex.com/apache/arrow-swift/badge.swift)](https://swiftpackageindex.com/apache/arrow-swift)

You can add Apache Arrow Swift to your project using Swift Package Manager. For complete installation instructions and version selection, see the [Swift Package Index page](https://swiftpackageindex.com/apache/arrow-swift/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that https://swiftpackageindex.com/apache/arrow-swift/ doesn't include "complete installation instructions". Should we write them by ourselves?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## Getting Started

TODO: We should refer auto generated documentation on Swift Package Index after we register this package to Swift Package Index.
You can browse API documentation and usage examples at our [Swift Package Index documentation page](https://swiftpackageindex.com/apache/arrow-swift/documentation). Once added, import Arrow in your code and get started!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that https://swiftpackageindex.com/apache/arrow-swift/documentation doesn't exist. Could you check it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +52 to +53


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert needless changes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve README.md after Publish Arrow Swift to Swift Package Index
2 participants