Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .spi.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
version: 1
builder:
configs:
- documentation_targets: [arrow-swift]
8 changes: 6 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@

## Install

TODO: We should update this after we register this package to Swift Package Index.
[![Swift Package Index](https://swiftpackageindex.com/apache/arrow-swift/badge.swift)](https://swiftpackageindex.com/apache/arrow-swift)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this badge URL is 404: https://swiftpackageindex.com/apache/arrow-swift/badge.swift

Could you check it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


You can add Apache Arrow Swift to your project using Swift Package Manager. For complete installation instructions and version selection, see the [Swift Package Index page](https://swiftpackageindex.com/apache/arrow-swift/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that https://swiftpackageindex.com/apache/arrow-swift/ doesn't include "complete installation instructions". Should we write them by ourselves?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## Getting Started

TODO: We should refer auto generated documentation on Swift Package Index after we register this package to Swift Package Index.
You can browse API documentation and usage examples at our [Swift Package Index documentation page](https://swiftpackageindex.com/apache/arrow-swift/documentation). Once added, import Arrow in your code and get started!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that https://swiftpackageindex.com/apache/arrow-swift/documentation doesn't exist. Could you check it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## Getting involved

Expand All @@ -47,3 +49,5 @@ If you'd like to report a bug but don't have time to fix it, you can still post
## License

[Apache 2.0](https://github.com/apache/arrow-swift/blob/main/LICENSE.txt)


Comment on lines +52 to +53
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert needless changes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove these