-
Notifications
You must be signed in to change notification settings - Fork 8
chore: Use Swift Package Index for how to install and documentation #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
version: 1 | ||
builder: | ||
configs: | ||
- documentation_targets: [arrow-swift] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,11 +23,13 @@ | |
|
||
## Install | ||
|
||
TODO: We should update this after we register this package to Swift Package Index. | ||
[](https://swiftpackageindex.com/apache/arrow-swift) | ||
|
||
You can add Apache Arrow Swift to your project using Swift Package Manager. For complete installation instructions and version selection, see the [Swift Package Index page](https://swiftpackageindex.com/apache/arrow-swift/). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems that https://swiftpackageindex.com/apache/arrow-swift/ doesn't include "complete installation instructions". Should we write them by ourselves? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these will be generated as described in https://swiftpackageindex.com/blog/auto-generating-auto-hosting-and-auto-updating-docc-documentation |
||
|
||
## Getting Started | ||
|
||
TODO: We should refer auto generated documentation on Swift Package Index after we register this package to Swift Package Index. | ||
You can browse API documentation and usage examples at our [Swift Package Index documentation page](https://swiftpackageindex.com/apache/arrow-swift/documentation). Once added, import Arrow in your code and get started! | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems that https://swiftpackageindex.com/apache/arrow-swift/documentation doesn't exist. Could you check it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these will be generated as described in https://swiftpackageindex.com/blog/auto-generating-auto-hosting-and-auto-updating-docc-documentation |
||
|
||
## Getting involved | ||
|
||
|
@@ -47,3 +49,5 @@ If you'd like to report a bug but don't have time to fix it, you can still post | |
## License | ||
|
||
[Apache 2.0](https://github.com/apache/arrow-swift/blob/main/LICENSE.txt) | ||
|
||
|
||
Comment on lines
+52
to
+53
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you revert needless changes? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will remove these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this badge URL is 404: https://swiftpackageindex.com/apache/arrow-swift/badge.swift
Could you check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these will be generated as described in https://swiftpackageindex.com/blog/auto-generating-auto-hosting-and-auto-updating-docc-documentation