Skip to content

Commit 41ce51b

Browse files
authored
GH-47537: [C++] Use pkgconfig name for benchmark in Meson (#47538)
### Rationale for this change Because of an inconsistency in the name of the pkgconfig file for google benchmark and the dependency exposed by Meson, Meson will always ignore a system install and fallback to building google benchmark locally. We can instead patch our Meson configuration to workaround the inconsistent naming ### What changes are included in this PR? We use the proper pkgconfig exposed name to find the dependency, and fallback to the Meson subproject / variable name combination as necessary ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: #47537 Authored-by: Will Ayd <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 066aaba commit 41ce51b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

cpp/src/arrow/meson.build

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,8 @@ endforeach
670670

671671
if needs_benchmarks
672672
benchmark_main_dep = dependency(
673-
'benchmark-main',
673+
'benchmark_main',
674+
fallback: ['google-benchmark', 'google_benchmark_main_dep'],
674675
default_options: {'tests': 'disabled'},
675676
)
676677

0 commit comments

Comments
 (0)