GH-47721: [C++][FlightRPC] Followup to remove unncessary std::move to resolve compliation flakiness

HyukjinKwon · HyukjinKwon · commit 6d3fb0dea947 · 2025-12-30T11:45:06.000+09:00
diff --git a/cpp/src/arrow/flight/sql/column_metadata.cc b/cpp/src/arrow/flight/sql/column_metadata.cc
@@ -59,8 +59,8 @@ const char* ColumnMetadata::kRemarks = "ARROW:FLIGHT:SQL:REMARKS";
 
 ColumnMetadata::ColumnMetadata(
     std::shared_ptr<const arrow::KeyValueMetadata> metadata_map) {
-  metadata_map_ = std::move(metadata_map ? metadata_map
-                                         : std::make_shared<arrow::KeyValueMetadata>());
+  metadata_map_ =
+      metadata_map ? metadata_map : std::make_shared<arrow::KeyValueMetadata>();
 }
 
 arrow::Result<std::string> ColumnMetadata::GetCatalogName() const {

Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,8 @@ const char* ColumnMetadata::kRemarks = "ARROW:FLIGHT:SQL:REMARKS";`
`59`	`59`
`60`	`60`	`ColumnMetadata::ColumnMetadata(`
`61`	`61`	`std::shared_ptr<const arrow::KeyValueMetadata> metadata_map) {`
`62`		`- metadata_map_ = std::move(metadata_map ? metadata_map`
`63`		`- : std::make_shared<arrow::KeyValueMetadata>());`
	`62`	`+ metadata_map_ =`
	`63`	`+ metadata_map ? metadata_map : std::make_shared<arrow::KeyValueMetadata>();`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`arrow::Result<std::string> ColumnMetadata::GetCatalogName() const {`